Skip to content

refactor: remove http module #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019
Merged

refactor: remove http module #1942

merged 1 commit into from
Aug 12, 2019

Conversation

tgpetrov
Copy link
Contributor

@tgpetrov tgpetrov commented Aug 9, 2019

PR Checklist

What is the current behavior?

There is a NativeScriptHttpModule that uses Angular deprecated APIs

What is the new behavior?

  • The NativeScriptHttpModule is removed
  • @angular/http is removed from the dependencies

Related with #1842 .

BREAKING CHANGES:

  • The NativeScriptHttpModule is removed
  • @angular/http is removed from the dependencies

Migration steps:

  • If using NativeScriptHttpModule, replace with NativeScriptHttpClientModule as done here
  • as @angular/http is no longer a peerDependency of nativescript-angular, you can remove if from your dependencies

@cla-bot cla-bot bot added the cla: yes label Aug 9, 2019
@tgpetrov tgpetrov force-pushed the tgpetrov/remove-http-module branch from e837a4b to c12d2e5 Compare August 12, 2019 07:19
@tgpetrov tgpetrov merged commit c6af21d into master Aug 12, 2019
@tgpetrov tgpetrov deleted the tgpetrov/remove-http-module branch August 12, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants